Fix FAB sheet backdrop when used in kirby-page #3009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2765
What is the new behavior?
The FAB sheet backdrop will take up the full height of the screen.
Does this PR introduce a breaking change?
Are there any additional context?
The cause of this issue is that one of the
kirby-page
div elements gets this styling from Ionic:transform: translateZ(0px)
. The backdrop component usesposition: fixed
, which under normal circumstances will position the element relative to the initial containing block established by the viewport, except when one of its ancestors hastransform
set to something other thannone
. See MDN documentation for position fixed.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.