Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAB sheet backdrop when used in kirby-page #3009

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes #2765

What is the new behavior?

The FAB sheet backdrop will take up the full height of the screen.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

The cause of this issue is that one of the kirby-page div elements gets this styling from Ionic: transform: translateZ(0px). The backdrop component uses position: fixed, which under normal circumstances will position the element relative to the initial containing block established by the viewport, except when one of its ancestors has transform set to something other than none. See MDN documentation for position fixed.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup added the fix Add this PR to the changelog as a bugfix label Apr 25, 2023
@mark-drastrup mark-drastrup requested a review from jkaltoft as a code owner April 25, 2023 10:30
@mark-drastrup mark-drastrup self-assigned this Apr 25, 2023
@github-actions github-actions bot temporarily deployed to pr-2765-fab-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs April 25, 2023 10:37 Inactive
@mark-drastrup mark-drastrup force-pushed the bug/2765-FAB-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs branch from e094c4a to 17f277a Compare April 25, 2023 11:12
@github-actions github-actions bot temporarily deployed to pr-2765-fab-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs April 25, 2023 11:17 Inactive
@mark-drastrup mark-drastrup force-pushed the bug/2765-FAB-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs branch from 17f277a to da6baef Compare May 10, 2023 14:24
@github-actions github-actions bot requested a deployment to pr-2765-fab-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs May 10, 2023 14:31 In progress
@RasmusKjeldgaard RasmusKjeldgaard merged commit 8be6271 into develop May 11, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2765-FAB-sheet-backdrop-does-not-show-up-correctly-when-used-inside-tabs branch May 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FAB sheet backdrop does not show up correctly when used inside Tabs
2 participants