Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend mock base chart for mock charts to work #3030

Merged
merged 1 commit into from
May 2, 2023

Conversation

RasmusKjeldgaard
Copy link
Collaborator

What is the new behavior?

Chart Mocks need to extend the BaseChartComponent for the API to match the real implementation.
For now this is a quickfix where I manually extend the already generated MockBaseChartComponent, until #3029 is implemented.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label May 2, 2023
@RasmusKjeldgaard RasmusKjeldgaard changed the title Extend mock base chart in mock charts Extend mock base chart for mock charts to work May 2, 2023
@RasmusKjeldgaard RasmusKjeldgaard merged commit 6200442 into develop May 2, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/extend-base-chart-in-mock branch May 2, 2023 06:14
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants