Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: interactive header title #3035

Merged
merged 7 commits into from
May 4, 2023
Merged

Enhancement: interactive header title #3035

merged 7 commits into from
May 4, 2023

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented May 3, 2023 •
edited
Loading

Which issue does this PR close?

This PR closes #3032

What is the new behavior?

Option to add interactivity to the header's title element in key value scenarios.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe requested a review from jkaltoft as a code owner May 3, 2023 11:42
@jakobe jakobe added the feature Add this PR to the changelog as a feature label May 3, 2023
@github-actions github-actions bot temporarily deployed to pr-3032-interactive-header-title May 3, 2023 11:48 Inactive
mark-drastrup
mark-drastrup reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! I only have a couple of minor comments for the cookbook :)

apps/cookbook/src/app/showcase/header-showcase/header-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/header-showcase/header-showcase.component.html Outdated Show resolved Hide resolved
jakobe and others added 3 commits May 3, 2023 16:39
@jakobe @mark-drastrup
docs: typo
50cf8d1 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@jakobe @mark-drastrup
docs: align heading levels
474455a 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@jakobe
Merge branch 'develop' into enhancement/3032-interactive-header-title
1690e7a
@jakobe jakobe enabled auto-merge (squash) May 3, 2023 14:41
@github-actions github-actions bot temporarily deployed to pr-3032-interactive-header-title May 3, 2023 14:46 Inactive
@github-actions github-actions bot had a problem deploying to pr-3032-interactive-header-title May 3, 2023 14:46 Failure
@jakobe jakobe merged commit 7e8b894 into develop May 4, 2023
@jakobe jakobe deleted the enhancement/3032-interactive-header-title branch May 4, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-drastrup mark-drastrup mark-drastrup approved these changes

@RasmusKjeldgaard RasmusKjeldgaard Awaiting requested review from RasmusKjeldgaard

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Interactive header title
2 participants
@jakobe @mark-drastrup