Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing highlight of items on keyboard navigation in dropdown when using popover #3066

Merged

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes #3062

What is the new behavior?

Items will now be highlighted when using the arrow keys to navigate a dropdown with [usePopover]="true".

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup added the fix Add this PR to the changelog as a bugfix label May 23, 2023
@mark-drastrup mark-drastrup requested a review from jkaltoft as a code owner May 23, 2023 13:51
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mark-drastrup mark-drastrup merged commit 813bad8 into develop May 23, 2023
@mark-drastrup mark-drastrup deleted the bug/3062-focus-lost-on-dropdown-when-using-popver branch May 23, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Focus lost on dropdown when using usePopover
2 participants