Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing icon now a part of utills and can use external icon #3093

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #3042

What is the new behavior?

Trailing icon is now a part of Kirby utils and can be used to set a custom trailing icon. Apart from Kirby icons it is now also able to use external icons. Cookbook link showcase is updated.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit requested a review from jkaltoft as a code owner June 8, 2023 06:14
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 8, 2023 06:20 Inactive
@AgreSanGit AgreSanGit self-assigned this Jun 8, 2023
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AgreSanGit ,
Implementation looks great 👌🏻
I have a few suggestions for improving and clarifying the docs 🤓

AgreSanGit and others added 3 commits June 8, 2023 10:12
…ponent.html

Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
…ponent.html

Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
…icon.ts

Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 8, 2023 08:18 Inactive
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 8, 2023 08:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 8, 2023 08:21 Inactive
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 8, 2023 08:53 Inactive
AgreSanGit and others added 3 commits June 14, 2023 12:37
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 14, 2023 10:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 14, 2023 10:44 Inactive
@github-actions github-actions bot temporarily deployed to pr-trailing-icon June 14, 2023 10:45 Inactive
…ponent.html

Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@jakobe jakobe enabled auto-merge (squash) June 15, 2023 09:42
@jakobe jakobe merged commit 5e5326a into develop Jun 15, 2023
@jakobe jakobe deleted the enhancement/trailing-icon branch June 15, 2023 09:47
@RasmusKjeldgaard RasmusKjeldgaard added the feature Add this PR to the changelog as a feature label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants