-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing icon now a part of utills and can use external icon #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobe
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AgreSanGit ,
Implementation looks great 👌🏻
I have a few suggestions for improving and clarifying the docs 🤓
apps/cookbook/src/app/showcase/link-showcase/link-showcase.component.html
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/showcase/link-showcase/link-showcase.component.html
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/examples/link-example/examples/trailing-icon.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/examples/link-example/examples/trailing-icon.ts
Outdated
Show resolved
Hide resolved
…ponent.html Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
…ponent.html Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
…icon.ts Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
jakobe
requested changes
Jun 12, 2023
apps/cookbook/src/app/examples/link-example/examples/trailing-icon.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/showcase/link-showcase/link-showcase.component.html
Outdated
Show resolved
Hide resolved
…icon.ts Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
…ponent.html Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
jakobe
reviewed
Jun 14, 2023
apps/cookbook/src/app/showcase/link-showcase/link-showcase.component.html
Outdated
Show resolved
Hide resolved
…ponent.html Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
jakobe
approved these changes
Jun 15, 2023
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3042
What is the new behavior?
Trailing icon is now a part of Kirby utils and can be used to set a custom trailing icon. Apart from Kirby icons it is now also able to use external icons. Cookbook link showcase is updated.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.