Page: add option to subscribe to toolbar title click #3111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3075
What is the new behavior?
It's already possible to subscribe to
Header.onTitleClick()
which also is emitted on toolbar title click, but in virtual scrolling scenarios the header gets removed from the DOM and the component instance destroyed, which prevents the event handler from being triggered.This PR adds a
toolbarTitleClick
event/output property.It also adds a
hasInteractiveTitle
prop to support overriding when the toolbar should be styled as clickable (i.e.cursor: pointer)
Does this PR introduce a breaking change?
Are there any additional context?
No.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
[ ] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
develop
by Team Kirby.