Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page: add option to subscribe to toolbar title click #3111

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Jun 22, 2023

Which issue does this PR close?

This PR closes #3075

What is the new behavior?

It's already possible to subscribe to Header.onTitleClick() which also is emitted on toolbar title click, but in virtual scrolling scenarios the header gets removed from the DOM and the component instance destroyed, which prevents the event handler from being triggered.

This PR adds a toolbarTitleClick event/output property.
It also adds a hasInteractiveTitle prop to support overriding when the toolbar should be styled as clickable (i.e. cursor: pointer)

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

No.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • [ ] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the feature Add this PR to the changelog as a feature label Jun 22, 2023
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jakobe jakobe merged commit 3abd42c into develop Jun 22, 2023
@jakobe jakobe deleted the enhancement/3075-page-add-option-to-subscribe-to-toolbar-title-click branch June 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Page: Add option to subscribe to toolbar title click
2 participants