Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn once about table deprecations #3118

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Jun 22, 2023

Which issue does this PR close?

This PR closes no issue

What is the new behavior?

We accidentally warn about table row and selectable deprecations for each instance of the table row component, which is of course not ideal for a component such as table with many individual rows:
image

A drawback of this solution is that we only warn for the first table that is instantiated in an application, but I believe it is a significant improvement as opposed to warning over and over again.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Jun 22, 2023
@github-actions github-actions bot temporarily deployed to pr-table-row-only-warn-once June 22, 2023 14:30 Inactive
@github-actions github-actions bot had a problem deploying to pr-table-row-only-warn-once June 22, 2023 14:30 Failure
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) June 22, 2023 14:46
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@RasmusKjeldgaard RasmusKjeldgaard merged commit 8acdce9 into develop Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/table-row-only-warn-once branch June 22, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants