Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct spacing on page actions buttons #3128

Merged

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Jun 28, 2023

Which issue does this PR close?

This PR closes #3127

What is the new behavior?

Ensures correct spacing on page actions buttons (8px)

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

No.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • [ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the fix Add this PR to the changelog as a bugfix label Jun 28, 2023
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@github-actions github-actions bot temporarily deployed to pr-3127-fix-spacing-between-buttons-in-kirby-page-actions June 28, 2023 06:56 Inactive
@jakobe jakobe merged commit 8850c18 into develop Jun 28, 2023
@jakobe jakobe deleted the bug/3127-fix-spacing-between-buttons-in-kirby-page-actions branch June 28, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix spacing between buttons in kirby-page-actions
2 participants