Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Add extra small checkboxes #3141

Merged
merged 36 commits into from
Feb 7, 2024

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #2991

What is the new behavior?

Extra small checkbox now gives a smaller checkbox.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit requested a review from jkaltoft as a code owner June 30, 2023 08:50
@AgreSanGit AgreSanGit self-assigned this Jun 30, 2023
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes June 30, 2023 08:57 Inactive
@AgreSanGit AgreSanGit added enhancement New feature or request component:Checkbox feature Add this PR to the changelog as a feature labels Jun 30, 2023
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! My only comment is to update the cookbook text, that says "The checkbox and checkmark always have the same size.", and to update the vertical placement of the "xs: 32px" in the example :)

@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes July 4, 2023 12:02 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes July 25, 2023 10:09 Inactive
@github-actions github-actions bot had a problem deploying to pr-2991-smaller-checkboxes August 4, 2023 08:12 Failure
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes August 4, 2023 08:26 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes August 31, 2023 08:45 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes August 31, 2023 09:03 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes September 7, 2023 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes September 8, 2023 06:45 Inactive
@AgreSanGit AgreSanGit changed the title Add extra small checkboxes Checkbox: Add extra small checkboxes Sep 14, 2023
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes January 30, 2024 10:19 Inactive
AgreSanGit and others added 2 commits February 6, 2024 21:23
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
@github-actions github-actions bot had a problem deploying to pr-2991-smaller-checkboxes February 6, 2024 20:28 Failure
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 6, 2024 20:28 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 6, 2024 20:48 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 6, 2024 20:49 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 6, 2024 20:53 Inactive
@github-actions github-actions bot had a problem deploying to pr-2991-smaller-checkboxes February 6, 2024 20:53 Failure
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 6, 2024 21:36 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 7, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-2991-smaller-checkboxes February 7, 2024 10:19 Inactive
@RasmusKjeldgaard RasmusKjeldgaard merged commit fcdd145 into develop Feb 7, 2024
5 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/2991-smaller-checkboxes branch February 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Checkbox enhancement New feature or request feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Smaller Checkboxes
3 participants