-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox: Add extra small checkboxes #3141
Merged
RasmusKjeldgaard
merged 36 commits into
develop
from
enhancement/2991-smaller-checkboxes
Feb 7, 2024
Merged
Checkbox: Add extra small checkboxes #3141
RasmusKjeldgaard
merged 36 commits into
develop
from
enhancement/2991-smaller-checkboxes
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-drastrup
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! My only comment is to update the cookbook text, that says "The checkbox and checkmark always have the same size.", and to update the vertical placement of the "xs: 32px" in the example :)
RasmusKjeldgaard
requested changes
Aug 4, 2023
apps/cookbook/src/app/showcase/checkbox-showcase/checkbox-showcase.component.html
Outdated
Show resolved
Hide resolved
…com/kirbydesign/designsystem into enhancement/2991-smaller-checkboxes
RasmusKjeldgaard
requested changes
Feb 5, 2024
apps/cookbook/src/app/showcase/checkbox-showcase/checkbox-showcase.component.html
Show resolved
Hide resolved
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
…com/kirbydesign/designsystem into enhancement/2991-smaller-checkboxes
…com/kirbydesign/designsystem into enhancement/2991-smaller-checkboxes
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
…com/kirbydesign/designsystem into enhancement/2991-smaller-checkboxes
RasmusKjeldgaard
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:Checkbox
enhancement
New feature or request
feature
Add this PR to the changelog as a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2991
What is the new behavior?
Extra small checkbox now gives a smaller checkbox.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.