Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox: implement ControlValueAccessor to trigger changes within Angular forms #3158

Merged
merged 54 commits into from
Nov 22, 2023
Merged

Checkbox: implement ControlValueAccessor to trigger changes within Angular forms #3158

merged 54 commits into from
Nov 22, 2023

Conversation

AgreSanGit
Copy link
Contributor

@AgreSanGit AgreSanGit commented Jul 6, 2023 •
edited
Loading

Which issue does this PR close?

This PR closes #2804

What is the new behavior?

ControlValueAccessor implemented so kirby checkbox does now trigger changes within reactive forms

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit added bug fix Add this PR to the changelog as a bugfix and removed bug labels Jul 6, 2023
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 6, 2023 12:31 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 6, 2023 13:49 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 7, 2023 08:10 Inactive
@AgreSanGit AgreSanGit self-assigned this Jul 10, 2023
mark-drastrup
mark-drastrup previously requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AgreSanGit :D I have have some nitty gritty comments! :)

libs/designsystem/checkbox/src/checkbox.component.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.spec.ts Outdated Show resolved Hide resolved
AgreSanGit and others added 7 commits July 12, 2023 09:35
@AgreSanGit @mark-drastrup
Update libs/designsystem/checkbox/src/checkbox.component.ts
38e2545 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@AgreSanGit @mark-drastrup
Update libs/designsystem/checkbox/src/checkbox.component.ts
90f310a 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@AgreSanGit @mark-drastrup
Update libs/designsystem/checkbox/src/checkbox.component.spec.ts
026333b 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@AgreSanGit @mark-drastrup
Update libs/designsystem/checkbox/src/checkbox.component.spec.ts
5d67895 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@AgreSanGit @mark-drastrup
Update libs/designsystem/checkbox/src/checkbox.component.spec.ts
6ee8f73 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@AgreSanGit
Pretter/Lint error correction after code review
cb1c245
@AgreSanGit
Prettier/Lint correction
368e799
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 14, 2023 12:36 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 18, 2023 13:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms July 25, 2023 10:18 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms August 4, 2023 08:12 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms August 31, 2023 09:27 Inactive
RasmusKjeldgaard
RasmusKjeldgaard requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on implementation and test!

Apart from a couple of minor suggestions, I think the only thing missing is a good example of this in a reactive form, like we have for radio-groups: https://cookbook.kirby.design/#/home/showcase/radio

libs/designsystem/checkbox/src/checkbox.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.ts Outdated Show resolved Hide resolved
libs/designsystem/checkbox/src/checkbox.component.ts Outdated Show resolved Hide resolved
@RasmusKjeldgaard
Copy link
Collaborator

I think we should label this as a feature instead of a fix. I know the original issue is a bug report, but we are adding a new feature cleanly here, not fixing existing functionality.

@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) October 2, 2023 11:11
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms October 2, 2023 11:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms October 5, 2023 11:25 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms November 2, 2023 08:36 Inactive
@RasmusKjeldgaard
Fix whitespace issues
7950e66
@RasmusKjeldgaard
Remove unique labelID
70a8ed1 
This is no longer needed and was removed in another PR but seems to have
been accidentally added back
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms November 21, 2023 12:47 Inactive
@github-actions github-actions bot temporarily deployed to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms November 21, 2023 12:48 Inactive
@github-actions github-actions bot had a problem deploying to pr-2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms November 21, 2023 12:48 Failure
@RasmusKjeldgaard RasmusKjeldgaard merged commit c1ba9ff into develop Nov 22, 2023
5 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2804-kirby-checkbox-does-not-trigger-changes-within-reactive-forms branch November 22, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

@jakobe jakobe jakobe approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

@mark-drastrup mark-drastrup Awaiting requested review from mark-drastrup

Assignees

@AgreSanGit AgreSanGit

Labels
feature Add this PR to the changelog as a feature
Projects
Kirby Sprints
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] kirby-checkbox does not trigger changes within reactive forms
4 participants
@AgreSanGit @RasmusKjeldgaard @jakobe @mark-drastrup