Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides: change showNavigation default to true #3213

Merged

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Aug 23, 2023

Which issue does this PR close?

This PR closes #3209

What is the new behavior?

Navigation arrows and slide indicator is now shown by default on kirby-slides.

Does this PR introduce a breaking change?

  • Yes
  • No

Migration notes added to MIGRATION.md.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard changed the title Slides showNavigation and remove warning Slides: change showNavigation default to true Aug 23, 2023
@github-actions github-actions bot temporarily deployed to pr-3209-slides-shownavigation-default-true August 23, 2023 17:16 Inactive
@RasmusKjeldgaard RasmusKjeldgaard marked this pull request as ready for review August 23, 2023 17:36
@github-actions github-actions bot temporarily deployed to pr-3209-slides-shownavigation-default-true August 23, 2023 17:37 Inactive
@RasmusKjeldgaard RasmusKjeldgaard added the breaking-change Add this PR to the changelog as a breaking change label Aug 23, 2023
jakobe
jakobe previously approved these changes Sep 7, 2023
@github-actions github-actions bot temporarily deployed to pr-3209-slides-shownavigation-default-true September 7, 2023 12:21 Inactive
@RasmusKjeldgaard RasmusKjeldgaard merged commit 7f94613 into develop Sep 7, 2023
5 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/3209-slides-shownavigation-default-true branch September 7, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Add this PR to the changelog as a breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Housekeeping] slides' showNavigation should default to true
2 participants