-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Banner: Add new image banner component #3501
Merged
Merged
+483
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
June 19, 2024 10:29
Inactive
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 8, 2024 15:35
Inactive
Loading status checks…
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 9, 2024 07:47
Inactive
github-actions
bot
had a problem deploying
to
pr-add-banner-extension-component
August 12, 2024 12:52
Failure
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 12, 2024 13:02
Inactive
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 12, 2024 13:29
Inactive
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
jakobe
reviewed
Aug 13, 2024
libs/extensions/angular/image-banner/src/image-banner.component.html
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.html
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.scss
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.scss
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 13, 2024 09:34
Inactive
github-actions
bot
temporarily deployed
to
pr-add-banner-extension-component
August 13, 2024 09:35
Inactive
jakobe
previously approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
jakobe
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻 🍂
10 tasks
RasmusKjeldgaard
added
ignore-for-release
Housekeeping, tooling etc. that have no relevance for consumers of Kirby
and removed
feature
Add this PR to the changelog as a feature
labels
Aug 20, 2024
RasmusKjeldgaard
added
feature
Add this PR to the changelog as a feature
and removed
ignore-for-release
Housekeeping, tooling etc. that have no relevance for consumers of Kirby
labels
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#3522
What is the new behavior?
This adds a new image-banner component to the angular extensions library.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.