Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Banner: Add new image banner component #3501

Merged
merged 40 commits into from
Aug 14, 2024

Conversation

hjorte-bankdata
Copy link
Collaborator

@hjorte-bankdata hjorte-bankdata commented Jun 18, 2024

Which issue does this PR close?

#3522

What is the new behavior?

This adds a new image-banner component to the angular extensions library.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

Sorry, something went wrong.

@hjorte-bankdata hjorte-bankdata self-assigned this Jun 18, 2024
@hjorte-bankdata hjorte-bankdata removed their assignment Jun 18, 2024
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component June 19, 2024 10:29 Inactive
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 8, 2024 15:35 Inactive
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 9, 2024 07:47 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot had a problem deploying to pr-add-banner-extension-component August 12, 2024 12:52 Failure
@RasmusKjeldgaard RasmusKjeldgaard added the feature Add this PR to the changelog as a feature label Aug 12, 2024
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 12, 2024 13:02 Inactive
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 12, 2024 13:29 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 13, 2024 09:34 Inactive
@github-actions github-actions bot temporarily deployed to pr-add-banner-extension-component August 13, 2024 09:35 Inactive
jakobe
jakobe previously approved these changes Aug 13, 2024
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻 🍂

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) August 14, 2024 12:14
@RasmusKjeldgaard RasmusKjeldgaard merged commit e031668 into develop Aug 14, 2024
10 of 12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the add-banner-extension-component branch August 14, 2024 12:20
@RasmusKjeldgaard RasmusKjeldgaard linked an issue Aug 19, 2024 that may be closed by this pull request
10 tasks
@RasmusKjeldgaard RasmusKjeldgaard added ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby and removed feature Add this PR to the changelog as a feature labels Aug 20, 2024
@RasmusKjeldgaard RasmusKjeldgaard added feature Add this PR to the changelog as a feature and removed ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[COMPONENT] Add banner-component to extensions library
3 participants