-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add keyboard support to slide button #3628
Merged
jkaltoft
merged 6 commits into
develop
from
enhancement/3605-add-keyboard-support-to-slide-button
Sep 27, 2024
Merged
Enhancement: Add keyboard support to slide button #3628
jkaltoft
merged 6 commits into
develop
from
enhancement/3605-add-keyboard-support-to-slide-button
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 24, 2024 11:34
Inactive
jkaltoft
force-pushed
the
enhancement/3605-add-keyboard-support-to-slide-button
branch
from
September 24, 2024 21:22
56e0c03
to
2d0a3e0
Compare
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 24, 2024 21:28
Inactive
jkaltoft
force-pushed
the
enhancement/3605-add-keyboard-support-to-slide-button
branch
from
September 25, 2024 15:49
2d0a3e0
to
fb75c1e
Compare
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 25, 2024 15:54
Inactive
jkaltoft
force-pushed
the
enhancement/3605-add-keyboard-support-to-slide-button
branch
from
September 25, 2024 20:51
7df110c
to
b129f95
Compare
jkaltoft
force-pushed
the
enhancement/3605-add-keyboard-support-to-slide-button
branch
from
September 25, 2024 21:33
b129f95
to
9ec67ab
Compare
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 25, 2024 21:47
Inactive
Fuzzy3
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice - plain and simple solution! I would like to have a UX' opinion on the "speed" of the sliding when using the keyboard. I would prefer to have it a little "faster"
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 26, 2024 13:36
Inactive
github-actions
bot
temporarily deployed
to
pr-3605-add-keyboard-support-to-slide-button
September 26, 2024 13:38
Inactive
Fuzzy3
approved these changes
Sep 27, 2024
jkaltoft
deleted the
enhancement/3605-add-keyboard-support-to-slide-button
branch
September 27, 2024 09:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3605
What is the new behavior?
Slide Button will listen for keyboard events, specifically the arrow keys, page up/down keys and the Home and End keys
When receiving keyboard focus a focus ring will be applied (visually) to the slider thumb.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.