Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add keyboard support to slide button #3628

Merged

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Sep 24, 2024

Which issue does this PR close?

This PR closes #3605

What is the new behavior?

Slide Button will listen for keyboard events, specifically the arrow keys, page up/down keys and the Home and End keys

When receiving keyboard focus a focus ring will be applied (visually) to the slider thumb.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jkaltoft jkaltoft linked an issue Sep 24, 2024 that may be closed by this pull request
14 tasks
@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 24, 2024 11:34 Inactive
@jkaltoft jkaltoft force-pushed the enhancement/3605-add-keyboard-support-to-slide-button branch from 56e0c03 to 2d0a3e0 Compare September 24, 2024 21:22
@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 24, 2024 21:28 Inactive
@jkaltoft jkaltoft force-pushed the enhancement/3605-add-keyboard-support-to-slide-button branch from 2d0a3e0 to fb75c1e Compare September 25, 2024 15:49
@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 25, 2024 15:54 Inactive
@jkaltoft jkaltoft force-pushed the enhancement/3605-add-keyboard-support-to-slide-button branch from 7df110c to b129f95 Compare September 25, 2024 20:51
@jkaltoft jkaltoft marked this pull request as ready for review September 25, 2024 21:14
@jkaltoft jkaltoft force-pushed the enhancement/3605-add-keyboard-support-to-slide-button branch from b129f95 to 9ec67ab Compare September 25, 2024 21:33
@jkaltoft jkaltoft added the feature Add this PR to the changelog as a feature label Sep 25, 2024
@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 25, 2024 21:47 Inactive
Copy link
Collaborator

@Fuzzy3 Fuzzy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice - plain and simple solution! I would like to have a UX' opinion on the "speed" of the sliding when using the keyboard. I would prefer to have it a little "faster"

@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 26, 2024 13:36 Inactive
@github-actions github-actions bot temporarily deployed to pr-3605-add-keyboard-support-to-slide-button September 26, 2024 13:38 Inactive
@jkaltoft jkaltoft merged commit 699ebc5 into develop Sep 27, 2024
12 checks passed
@jkaltoft jkaltoft deleted the enhancement/3605-add-keyboard-support-to-slide-button branch September 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add keyboard support to Slide Button
2 participants