Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Button: respect disabled state of slotted buttons #3633

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes no issue

What is the new behavior?

Previously, clicking a disabled button inside the toggle button would still change the state of the toggle button.
Now the toggle button respects the disabled state of any button inside.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Sep 25, 2024
@github-actions github-actions bot temporarily deployed to pr-toggle-button-disabled September 25, 2024 08:58 Inactive
@github-actions github-actions bot had a problem deploying to pr-toggle-button-disabled September 25, 2024 08:59 Failure
@github-actions github-actions bot temporarily deployed to pr-toggle-button-disabled September 25, 2024 09:12 Inactive
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Sep 25, 2024
@RasmusKjeldgaard RasmusKjeldgaard merged commit 24570bd into develop Sep 25, 2024
12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/toggle-button-disabled branch September 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants