Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons: Add basket, contract, expand, flower, house and tractor #3641

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Icons: Add basket, contract, expand, flower, house and tractor #3641

merged 1 commit into from
Sep 27, 2024

Conversation

jkaltoft
Copy link
Collaborator

Which issue does this PR close?

This PR closes #3491

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jkaltoft jkaltoft linked an issue Sep 27, 2024 that may be closed by this pull request
[Enhancement]Add Icons to Kirby #3491
Closed
11 tasks
@jkaltoft jkaltoft marked this pull request as ready for review September 27, 2024 10:46
jakobe
jakobe approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iconic! 💫

@jkaltoft jkaltoft merged commit 67130f3 into develop Sep 27, 2024
12 checks passed
@jkaltoft jkaltoft deleted the enhancement/3491-add-icons-to-kirby branch September 27, 2024 13:53
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Sep 27, 2024
Closed
@jkaltoft jkaltoft added the feature Add this PR to the changelog as a feature label Oct 9, 2024
RasmusKjeldgaard pushed a commit that referenced this pull request Oct 10, 2024
@jkaltoft @RasmusKjeldgaard
Icons: Add basket, contract, expand, flower, house and tractor (#3641)
1dfe5b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobe jakobe jakobe approved these changes

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]Add Icons to Kirby
2 participants
@jkaltoft @jakobe