Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Banner: use container queries to support usage in kirby-grid and kirby-slides #3664

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

troelslenda
Copy link
Collaborator

@troelslenda troelslenda commented Oct 11, 2024

Which issue does this PR close?

This PR closes #3663

What is the new behavior?

Use container queries for responsive behavior instead of relying on viewport width. This will support usage in kirby-grid, kirby-slides and many other usecases.

Displayed in the new storybook story.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@troelslenda troelslenda requested a review from jkaltoft as a code owner October 11, 2024 08:50
@github-actions github-actions bot temporarily deployed to pr-3663-container-queries October 11, 2024 08:55 Inactive
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I have some comments you can consider.
Most of it are just suggestions, but I would prefer if the docs-related comments are taken care of before I approve.

@troelslenda troelslenda force-pushed the enhancement/3663-container-queries branch from 6898a0c to 9a2d45c Compare October 11, 2024 16:52
@github-actions github-actions bot temporarily deployed to pr-3663-container-queries October 11, 2024 16:57 Inactive
@github-actions github-actions bot temporarily deployed to pr-3663-container-queries October 14, 2024 09:35 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the title Experiement with container queries in image-banner Image banner: use container queries to support usage in kirby-grid and kirby-slides Oct 14, 2024
@RasmusKjeldgaard RasmusKjeldgaard changed the title Image banner: use container queries to support usage in kirby-grid and kirby-slides Image Banner: use container queries to support usage in kirby-grid and kirby-slides Oct 14, 2024
@RasmusKjeldgaard RasmusKjeldgaard added the feature Add this PR to the changelog as a feature label Oct 14, 2024
@github-actions github-actions bot temporarily deployed to pr-3663-container-queries October 14, 2024 10:53 Inactive
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) October 14, 2024 12:04
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this!

@RasmusKjeldgaard RasmusKjeldgaard merged commit a4cac2a into develop Oct 14, 2024
12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/3663-container-queries branch October 14, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Extensions: Image-banner using container queries instead.
2 participants