-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Banner: use container queries to support usage in kirby-grid and kirby-slides #3664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I have some comments you can consider.
Most of it are just suggestions, but I would prefer if the docs-related comments are taken care of before I approve.
libs/extensions/angular/image-banner/src/image-banner.component.scss
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.scss
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/extensions/angular/image-banner/src/image-banner.component.scss
Outdated
Show resolved
Hide resolved
6898a0c
to
9a2d45c
Compare
libs/extensions/angular/image-banner/src/image-banner.component.stories.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for contributing this!
Which issue does this PR close?
This PR closes #3663
What is the new behavior?
Use container queries for responsive behavior instead of relying on viewport width. This will support usage in kirby-grid, kirby-slides and many other usecases.
Displayed in the new storybook story.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.