Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: fix failing tests #3711

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Housekeeping: fix failing tests #3711

merged 3 commits into from
Nov 15, 2024

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Nov 15, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes no issues, fixes failing tests in Chrome v131+

What is the new behavior?

Tests passes.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added housekeeping ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby labels Nov 15, 2024
jakobe and others added 2 commits November 15, 2024 14:19
@jakobe
💡 add missing comment
758e157
@jakobe @RasmusKjeldgaard
✏️ fix typo
03d6988 
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
RasmusKjeldgaard
RasmusKjeldgaard approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇

@jakobe jakobe enabled auto-merge (squash) November 15, 2024 13:21
@github-actions github-actions bot temporarily deployed to pr-fix-failing-tests-in-chrome-v131 November 15, 2024 13:22 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the title Houskeeping: fix failing tests Housekeeping: fix failing tests Nov 15, 2024
@jakobe jakobe merged commit 1e82b33 into develop Nov 15, 2024
6 of 9 checks passed
@jakobe jakobe deleted the housekeeping/fix-failing-tests-in-chrome-v131 branch November 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

Assignees
No one assigned
Labels
housekeeping ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobe @RasmusKjeldgaard