Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon: margin is missing when slotted to the end inside Item #3723

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Icon: margin is missing when slotted to the end inside Item #3723

merged 3 commits into from
Nov 26, 2024

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Nov 22, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3722

What is the new behavior?

Ensures correct margin on Icon when slotted the end inside Item

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the fix Add this PR to the changelog as a bugfix label Nov 22, 2024
@github-actions github-actions bot temporarily deployed to pr-3722-icon-margin-is-missing-when-slotted-to-the-end-inside-item November 22, 2024 10:49 Inactive
@jakobe jakobe enabled auto-merge (squash) November 22, 2024 11:32
Fuzzy3
Fuzzy3 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Fuzzy3 Fuzzy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@jakobe jakobe merged commit a39ba7c into develop Nov 26, 2024
12 checks passed
@jakobe jakobe deleted the bug/3722-icon-margin-is-missing-when-slotted-to-the-end-inside-Item branch November 26, 2024 09:17
Fuzzy3 pushed a commit that referenced this pull request Nov 27, 2024
@jakobe @Fuzzy3
Icon: margin is missing when slotted to the end inside Item (#3723)
0409ab6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzy3 Fuzzy3 Fuzzy3 approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Icon: margin is missing when slotted to the end inside Item
2 participants
@jakobe @Fuzzy3