Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item: improve styling for slotted textual content #3734

Merged
merged 38 commits into from
Dec 10, 2024
Merged

Item: improve styling for slotted textual content #3734

merged 38 commits into from
Dec 10, 2024

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Dec 6, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3721

What is the new behavior?

Adds support for global typography in Item 💅🏻

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe requested a review from jkaltoft as a code owner December 6, 2024 12:37
@jakobe jakobe added the feature Add this PR to the changelog as a feature label Dec 6, 2024
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 6, 2024 12:42 Inactive
@jakobe jakobe marked this pull request as draft December 6, 2024 12:49
@jakobe jakobe marked this pull request as ready for review December 9, 2024 14:54
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 9, 2024 15:11 Inactive
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 08:19 Inactive
Fuzzy3
Fuzzy3 reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@Fuzzy3 Fuzzy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome !! 💕

libs/designsystem/item/src/_item.utils.scss Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/fonts-showcase/fonts-showcase.component.html Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 08:54 Inactive
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 09:13 Inactive
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 10:54 Inactive
@github-actions github-actions bot had a problem deploying to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 10:54 Failure
RasmusKjeldgaard
RasmusKjeldgaard reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, stellar 🥇

apps/cookbook/src/app/examples/fonts-example/fonts-example.component.html Outdated Show resolved Hide resolved
libs/designsystem/item/src/_item.utils.scss Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/item-showcase/item-showcase.component.html Show resolved Hide resolved
libs/designsystem/item/src/_item.utils.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-3721-item-improve-styling-for-slotted-textual-content December 10, 2024 11:38 Inactive
@jakobe jakobe enabled auto-merge (squash) December 10, 2024 13:38
@jakobe jakobe merged commit 16819f6 into develop Dec 10, 2024
10 of 12 checks passed
@jakobe jakobe deleted the enhancement/3721-item-improve-styling-for-slotted-textual-content branch December 10, 2024 20:37
Fuzzy3 pushed a commit that referenced this pull request Dec 11, 2024
@jakobe @RasmusKjeldgaard @Fuzzy3
Item: improve styling for slotted textual content (#3734)
08db4ba 
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzy3 Fuzzy3 Fuzzy3 left review comments

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Item: improve styling for slotted textual content
3 participants
@jakobe @Fuzzy3 @RasmusKjeldgaard