Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move example files to an appropriate directory #96

Closed
wants to merge 4 commits into from

Conversation

lon-io
Copy link

@lon-io lon-io commented Jun 13, 2018

No description provided.

@kirill-konshin
Copy link
Owner

Can't merge while CI is failing, please fix.

@lon-io
Copy link
Author

lon-io commented Jun 13, 2018

I tried to point the example directory to next by doing:

"next": "next example",
"next:export": "next export example",
"next:build": "next build example",
"next:start": "next start example",

But it turns out babel-loader won't transpile files from outer directories:
babel/babel-loader#293

So I reverted back to the initial structure with some modifications

@kirill-konshin
Copy link
Owner

kirill-konshin commented Jun 13, 2018

But it turns out babel-loader won't transpile files from outer directories

This was exactly the reason why it was laid out the way it was.

Closing because PR now contain only stylistic changes.

@lon-io lon-io deleted the example branch June 13, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants