Add export options to improve the returned image output #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds a prop that allows the export of the cropped image through onCrop to be in a squared format of the cropped area. This allows the storage of a squared image to be future-proof, when deciding to use squared images instead of circular images.
This commit allows the returned image in onCrop to be an jpeg instead of in a PNG format. This simplifies the workflow when working with avatar images that should be in JPEG format.
This is helpful to ensure all profile images do have the same size. It also allows the exported images to be a higher quality to what is displayed in the circle.
This was referenced Nov 3, 2020
kevinvn1709
approved these changes
Mar 1, 2021
|
I've been using this foxylion fork in production-- I think these are great features. Thank you all for working on this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a prop that allows the export of the cropped image through onCrop to be in a squared format of the cropped area.
This allows the storage of a squared image to be future-proof, when deciding to use squared images instead of circular images.
This commit allows the returned image in onCrop to be an jpeg instead of in a PNG format. This simplifies the workflow when working with avatar images that should be in JPEG format.
This is helpful to ensure all profile images do have the same size. It also allows the exported images to be a higher quality to what is displayed in the circle.