Add debounce to server side listener #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried it in my project and it looks like a real solution for the problem. 👍 |
|
This solution looks great! 👏 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyed by this again, it suddenly hit me that the debounce could just be on the server side instead.
This will fix the problem of a template update triggering twice when TailwindCSS: once for the template file and once for the updated CSS. This would lead to unreliable reloads.
I opted to disable it as default, as it does add a slight delay to all updates. Definitely worth it if you use Tailwind though!
Also included a note to the README about not
data-turbo-tracking assets in dev. Same, with Tailwind, any template change would trigger a CSS rebuild and because ofdata-turbo-trackit would lead to a complete refresh of the page, breaking scroll restoration.This also seems to be the issue in #56