Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: components #229

Merged
merged 14 commits into from
Sep 7, 2023
Merged

feat: components #229

merged 14 commits into from
Sep 7, 2023

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Sep 7, 2023

📜 Description

Added KeyboardAvoidingView based on useKeyboardHandler hook.

💡 Motivation and Context

It was requested functionality and I agree that similar components should be provided out-of-box.

As a first component I decided to re-implement KeyboardAvoidingView, because the implementation is very easy 👀

Later I'm planning to add more components, so stay tuned 😎

Closes #154

📢 Changelog

JS

  • added KeyboardAvoidingView;
  • added corresponding example app.

Docs

  • added section about KeyboardAvoidingView;
  • added lottie that shows visual difference between implementations.

🤔 How Has This Been Tested?

Tested on:

  • Xiaomi Redmi Note 5 Pro;
  • Pixel 7 Pro;
  • iPhone 14 Pro (iOS 16.5, iOS 17) <- simulator;
  • iPhone 6s (iOS 15.6).

📸 Screenshots (if appropriate):

demo-kav.mov

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added enhancement New feature or request 📚 components Anything related to the exported components of this library labels Sep 7, 2023
@kirillzyusko kirillzyusko self-assigned this Sep 7, 2023
@kirillzyusko kirillzyusko added the documentation Improvements or additions to documentation label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

📊 Package size report

Current size Target Size Difference
70553 bytes 63603 bytes 6950 bytes 📈

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-07 15:56 UTC

@kirillzyusko kirillzyusko changed the title feat: components feat: components (KeyboardAvoidingView) Sep 7, 2023
@kirillzyusko kirillzyusko changed the title feat: components (KeyboardAvoidingView) feat: components Sep 7, 2023
@kirillzyusko kirillzyusko marked this pull request as ready for review September 7, 2023 13:44
@kirillzyusko kirillzyusko merged commit d887ec6 into main Sep 7, 2023
@kirillzyusko kirillzyusko deleted the feat/components branch September 7, 2023 15:54
@kirillzyusko kirillzyusko added the KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 components Anything related to the exported components of this library documentation Improvements or additions to documentation enhancement New feature or request KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Simple component for keyboard avoiding
2 participants