-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dismiss keeping focus #720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
e2e
Anything about E2E tests
🚨 requires API changes 🚨
Changes that requires changes in library API
labels
Dec 7, 2024
|
📊 Package size report
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
kirillzyusko
force-pushed
the
feat/dismiss-keep-focus
branch
from
December 9, 2024 09:29
2463a72
to
5eaa447
Compare
kirillzyusko
force-pushed
the
feat/dismiss-keep-focus
branch
from
December 9, 2024 13:51
5eaa447
to
1e059c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
e2e
Anything about E2E tests
enhancement
New feature or request
example
Anything related to example project
🚨 requires API changes 🚨
Changes that requires changes in library API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added an ability to dismiss keyboard while keeping focus.
💡 Motivation and Context
📢 Changelog
Docs
keepFocus
flag;E2E
JS
DismissOptions
todismiss
method;keepFocus
flag;iOS
KeyboardControllerModuleImpl
file;keepFocus
;TextInput
protocol with new props;inputView
when we callsetFocusTo("current")
;Android
view.clearFocus()
conditionally depending onkeepFocus
flag;🤔 How Has This Been Tested?
Tested manually on:
📸 Screenshots (if appropriate):
telegram-cloud-document-2-5386359558685877476.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-10.at.12.00.00.mp4
telegram-cloud-document-2-5386318305524997022.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-10.at.11.59.12.mp4
📝 Checklist