support for new Chrome audio context #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome no longer uses webkitAudioContext. Instead has it's own AudioContext. First made change to init lowLag's audioContext with the chrome version if webkitAudioContext doesn't exist. Then, most recent versions of chrome use promises to decode the audio, instead of a callback style. (Not sure when that change took place?) So now when using audioContexts (webkit or chrome) will try both callback and promise methods. Then, Chrome's audio context also doesn't necessarily handle all the same audio formats that webkit did. For example, on OSX most recent chrom audioContext does not handle .aiff files. So I change the audio context loading function to recursively call itself if it cannot load the first url in the array of urls. Now, audioContext loads should try all attempted urls just sm2 and audioTag. I tested this on OSX safari and chrome (most recent versions).
... to reflect that webkit/chrome will now try all the provided urls
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge addresses the fact that chrome now longer uses webkitAudioContext. In this update, chrome will call the correct function to create an audio context. Also, chrome/webkit loads will now try all the provided urls. This addresses issues #13 and maybe #3.