Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update method name to start webkit sounds #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpuffer
Copy link

@jpuffer jpuffer commented Jul 18, 2014

Fix critical bug causing JS error in newest Chrome.

Chrome v.36 no longer supports the noteOn method, so replace it with
the newer start method.
See following reference:

https://code.google.com/p/chromium/issues/detail?id=358398

https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Porting_w
ebkitAudioContext_code_to_standards_based_AudioContext#Changes_to_method
s_used_to_start.2Fstop_AudioBufferSourceNode_and_OscillatorNode

Chrome v.36 no longer supports the `noteOn` method, so replace it with
the newer `start` method.
See following reference:

https://code.google.com/p/chromium/issues/detail?id=358398

https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Porting_w
ebkitAudioContext_code_to_standards_based_AudioContext#Changes_to_method
s_used_to_start.2Fstop_AudioBufferSourceNode_and_OscillatorNode
@jaredcat
Copy link

Think this can be closed now lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants