Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collaboration on updates to address issue #7 #9

Merged
merged 12 commits into from
Dec 10, 2018
Merged

Conversation

myusrn
Copy link

@myusrn myusrn commented Dec 10, 2018

collaboration on updates to that close issue #7 , User.IsInRole() now working

robertob and others added 12 commits December 9, 2018 17:34
…header data to create identity and principal vs unnecessary network request to /.auth/me
…eter name in GenericIdentity() call and request headers string access syntax
…yauth headers and .auth/me json payload cases
now the business logik for the different methods are
in seperate services.
…of new ClaimsIdentity/Principal code that allows IsInRole() checks to work
I refactor a lot of you and our changes
@paule96 paule96 self-requested a review December 10, 2018 20:38
Copy link
Collaborator

@paule96 paule96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay because I refactor it 👍

@kirkone kirkone merged commit 669a9c4 into kirkone:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants