Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a new debugPreStep configuration parameter in launch config #42

Closed
ptrthomas opened this issue May 2, 2020 · 8 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ptrthomas
Copy link
Collaborator

On the Karate debug-server side, I've added support for a pre-step hook. This is explained here:

https://github.com/intuit/karate/wiki/ZIP-Release#pre-step-hook

In fact it works without any change needed on the VS Code plugin side. I think the only change needed is to declare it, else you get the warning squiggle as seen below:

image

By the way I implemented the "Copy Value" feature as explained here: microsoft/vscode#27950 (comment)
image

just mentioning in case this is something you'd like to add to the karate-runner documentation as well.

testing both the above should be simple, just build the karate.jar as per the developer guide: https://github.com/intuit/karate/wiki/Developer-Guide#build-standalone-jar-and-zip

@kirksl
Copy link
Owner

kirksl commented May 2, 2020

@ptrthomas nice additions. ill try to get to this soon. will Karate just ignore debugPreStep in the debug config if using a version of Karate that doesn't support it yet? also can I document this will be in 0.9.6?

@kirksl kirksl self-assigned this May 2, 2020
@ptrthomas
Copy link
Collaborator Author

  • yes it will be gracefully ignored
  • yes should be in 0.9.6 for sure and planning 0.9.6.RC3 in a couple of days

@kirksl kirksl added the in development Currently in development label May 2, 2020
kirksl added a commit that referenced this issue May 3, 2020
@kirksl kirksl removed the in development Currently in development label May 3, 2020
@kirksl
Copy link
Owner

kirksl commented May 3, 2020

now supported in debug configurations. i left it out of the snippets though so a user would have to explicitly specify it by typing it in. let me know if you think that is ok. also didn't document anything about usage of the debugger. there's so much to the debugger that i hoped users would goto the VSCode documentation to understand how to use it and all of it's features. 36ba80d

@kirksl kirksl closed this as completed May 3, 2020
@ptrthomas
Copy link
Collaborator Author

@kirksl I think you have a canned snippet for the debugPreStep can you please change the comma to a +, this is because I decided to change the API slightly, apologies

image

since I'm here can I ask - have you documented the need to switch the terminal from "PowerShell" to cmd.exe anyplace that I can point users to ? I'm finding this is a must-do when using the Karate Runner on Windows.

@ptrthomas
Copy link
Collaborator Author

I'm going to paste some images here so that I can refer to them in wikis :)

image

image

@kirksl
Copy link
Owner

kirksl commented May 21, 2020

@ptrthomas no worries. i'll reopen to reshape that canned code snippet. regarding switching to cmd.exe yes it's at the bottom of the readme also reflected in the VSCode market place here -->
image

@kirksl kirksl reopened this May 21, 2020
@ptrthomas
Copy link
Collaborator Author

@kirksl thanks ! also one more minor change, omit the robot. it can just be:

input(Key.ALT + Key.TAB)

@kirksl
Copy link
Owner

kirksl commented May 21, 2020

fixed. 5b25104

@kirksl kirksl closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants