Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support local config file watcher of client and server #2

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

ozline
Copy link
Collaborator

@ozline ozline commented Dec 16, 2023

  • feat: support local file config of client and server

  • del: .DS_Store

  • add: license header

  • fix: staticcheck error report

  • fix: use NewRetryContainerWithPercentageLimit to create retry container

  • docs: correct sentence placement

  • fix: use individual module in example folder

  • feat: merge ClientWatcher and ServerWatcher into ConfigWatcher

  • fix: update error judgment of utils.PathExists()

  • docs: update README.md

  • chore: move example folder to kitex-contrib/example

  • fix: set alias for client/server to avoid same package name

  • fix: delete useless log

  • fix: add recover for new goroutines to avoid crashing

  • add: comments for exported symbols

  • del: monitor/key.go

  • feat: separating filewatch and configmonitor

  • docs: update README.md

  • fix: README.md usage import package error

  • add: monitor test cases

  • test: add entire progress test

  • fix: add mutex for start/stop file watching

  • fix: staticcheck error report

  • fix: multiple clients can listen to the same key without affecting each other

  • delete: remove the gomock module and use self-made simple mock instead

  • feat: upgrade required module version

  • fix: remove redundant golang versions in workflow tests

  • add: use example of this lib

  • fix: README_CN.md spell error

  • chore: README add supported file types

  • fix: panic when type assertion fails at runtime

  • chore: add log while callback is nil

  • fix: README.md lib name error

  • chore: add licenses


What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

* feat: support local file config of client and server

* del: .DS_Store

* add: license header

* fix: staticcheck error report

* fix: use NewRetryContainerWithPercentageLimit to create retry container

* docs: correct sentence placement

* fix: use individual module in example folder

* feat: merge ClientWatcher and ServerWatcher into ConfigWatcher

* fix: update error judgment of utils.PathExists()

* docs: update README.md

* chore: move example folder to kitex-contrib/example

* fix: set alias for client/server to avoid same package name

* fix: delete useless log

* fix: add recover for new goroutines to avoid crashing

* add: comments for exported symbols

* del: monitor/key.go

* feat: separating filewatch and configmonitor

* docs: update README.md

* fix: README.md usage import package error

* add: monitor test cases

* test: add entire progress test

* fix: add mutex for start/stop file watching

* fix: staticcheck error report

* fix: multiple clients can listen to the same key without affecting each other

* delete: remove the gomock module and use self-made simple mock instead

* feat: upgrade required module version

* fix: remove redundant golang versions in workflow tests

* add: use example of this lib

* fix: README_CN.md spell error

* chore: README add supported file types

* fix: panic when type assertion fails at runtime

* chore: add log while callback is nil

* fix: README.md lib name error

* chore: add licenses

---------

Co-authored-by: kinggo <lilong.21@bytedance.com>
@ozline ozline changed the title feat: support local config file watcher of client and server (#1) feat: support local config file watcher of client and server Dec 16, 2023
@li-jin-gou li-jin-gou merged commit 90fb161 into main Dec 16, 2023
8 of 9 checks passed
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: li-jin-gou, ozline

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozline ozline deleted the dev branch December 16, 2023 16:09
Ricky-chen1 pushed a commit to Ricky-chen1/config-file that referenced this pull request Feb 12, 2024
…ontrib#1) (kitex-contrib#2)

* feat: support local file config of client and server

* del: .DS_Store

* add: license header

* fix: staticcheck error report

* fix: use NewRetryContainerWithPercentageLimit to create retry container

* docs: correct sentence placement

* fix: use individual module in example folder

* feat: merge ClientWatcher and ServerWatcher into ConfigWatcher

* fix: update error judgment of utils.PathExists()

* docs: update README.md

* chore: move example folder to kitex-contrib/example

* fix: set alias for client/server to avoid same package name

* fix: delete useless log

* fix: add recover for new goroutines to avoid crashing

* add: comments for exported symbols

* del: monitor/key.go

* feat: separating filewatch and configmonitor

* docs: update README.md

* fix: README.md usage import package error

* add: monitor test cases

* test: add entire progress test

* fix: add mutex for start/stop file watching

* fix: staticcheck error report

* fix: multiple clients can listen to the same key without affecting each other

* delete: remove the gomock module and use self-made simple mock instead

* feat: upgrade required module version

* fix: remove redundant golang versions in workflow tests

* add: use example of this lib

* fix: README_CN.md spell error

* chore: README add supported file types

* fix: panic when type assertion fails at runtime

* chore: add log while callback is nil

* fix: README.md lib name error

* chore: add licenses

---------

Co-authored-by: kinggo <lilong.21@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants