Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-file part degradation #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,24 @@ Example:
}
}
```
##### Degradation: Category=degradation

[JSON Schema](https://github.com/cloudwego/kitex/blob/develop/pkg/#L30)

|Variable|Introduction|
|------------|----|
| percentage | The percentage of dropped requests|

Example:
default configuration(false,0)
```json
{
"degradation": {
"enabled": true,
"percentage": 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting percentage as 0 is kinda weird when degradation is enabled.
It's a good idea to make the documentation more uniform, see config-etcd, etc.

}
}
```
Note: The circuit breaker implementation of kitex does not currently support changing the global default configuration (see [initServiceCB](https://github.com/cloudwego/kitex/blob/v0.5.1/pkg/circuitbreak/cbsuite.go#L195) for details).
### More Info

Expand Down Expand Up @@ -374,6 +391,10 @@ For client configuration, you should write all their configurations in the same
}
}
}
},
"degradation": {
"enabled": true,
"percentage": 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

}
}
}
Expand Down
23 changes: 23 additions & 0 deletions README_CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,25 @@ echo 方法使用下面的配置(0.3、100),其他方法使用全局默认
}
```
注:kitex 的熔断实现目前不支持修改全局默认配置(详见 [initServiceCB](https://github.com/cloudwego/kitex/blob/v0.5.1/pkg/circuitbreak/cbsuite.go#L195))

##### 降级: Category=degradation

[JSON Schema](https://github.com/cloudwego/kitex/blob/develop/pkg/#L30)

|参数|说明|
|----|----|
| percentage | 丢弃比例 |

样例:
默认配置(false,0)
```json
{
"degradation": {
"enabled": true,
"percentage": 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

}
}
```
### 更多信息

更多示例请参考 [example](https://github.com/kitex-contrib/config-file/tree/main/example)
Expand Down Expand Up @@ -374,6 +393,10 @@ echo 方法使用下面的配置(0.3、100),其他方法使用全局默认
}
}
}
},
"degradation": {
"enabled": true,
"percentage": 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

}
}
}
Expand Down
45 changes: 45 additions & 0 deletions client/degradation.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
// Copyright 2024 CloudWeGo Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package client

import (
kitexclient "github.com/cloudwego/kitex/client"
"github.com/kitex-contrib/config-file/monitor"
degradation "github.com/kitex-contrib/config-file/pkg"
)

func WithDegradation(watcher monitor.ConfigMonitor) []kitexclient.Option {
container, keyDegradation := initDegradationOptions(watcher)
return []kitexclient.Option{
kitexclient.WithACLRules(container.GetAclRule()),
kitexclient.WithCloseCallbacks(func() error {
watcher.DeregisterCallback(keyDegradation)
return nil
}),
}
}

func initDegradationOptions(watcher monitor.ConfigMonitor) (*degradation.Container, int64) {
degradationContainer := degradation.NewContainer()
onChangeCallback := func() {
config := getFileConfig(watcher)
if config == nil {
return // config is nil, do nothing, log will be printed in getFileConfig
}
degradationContainer.NotifyPolicyChange(config.Degradation)
}
keyDegradation := watcher.RegisterCallback(onChangeCallback)
return degradationContainer, keyDegradation
}
1 change: 1 addition & 0 deletions client/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func (s *FileConfigClientSuite) Options() []kitexclient.Option {
opts = append(opts, WithRetryPolicy(s.watcher)...)
opts = append(opts, WithCircuitBreaker(s.service, s.watcher)...)
opts = append(opts, WithRPCTimeout(s.watcher)...)
opts = append(opts, WithDegradation(s.watcher)...)
opts = append(opts, kitexclient.WithCloseCallbacks(func() error {
s.watcher.Stop()
return nil
Expand Down
4 changes: 4 additions & 0 deletions example/client/kitex_client.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@
}
}
}
},
"degradation": {
"enabled": true,
"percentage": 0
}
}
}
2 changes: 2 additions & 0 deletions parser/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ import (
"github.com/cloudwego/kitex/pkg/circuitbreak"
"github.com/cloudwego/kitex/pkg/retry"
"github.com/cloudwego/kitex/pkg/rpctimeout"
degradation "github.com/kitex-contrib/config-file/pkg"
)

// ClientFileConfig is config of a client/service pair
type ClientFileConfig struct {
Timeout map[string]*rpctimeout.RPCTimeout `mapstructure:"timeout"` // key: method, "*" for default
Retry map[string]*retry.Policy `mapstructure:"retry"` // key: method, "*" for default
Circuitbreaker map[string]*circuitbreak.CBConfig `mapstructure:"circuitbreaker"` // key: method
Degradation *degradation.DegradationConfig `mapstructure:"degradation"`
}

// ClientFileManager is a map of client/service pairs to ClientFileConfig
Expand Down
81 changes: 81 additions & 0 deletions pkg/degradation.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
// Copyright 2024 CloudWeGo Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package degradation

import (
"context"
"errors"
"sync/atomic"

"github.com/bytedance/gopkg/lang/fastrand"
"github.com/cloudwego/configmanager/iface"
"github.com/cloudwego/kitex/pkg/acl"
)

var errRejected = errors.New("rejected by client degradation config")

var defaultConfig = &DegradationConfig{
Enable: false,
Percentage: 0,
}

type DegradationConfig struct {
Enable bool `json:"enabled"`
Percentage int `json:"percentage"`
}

// DeepCopy returns a copy of the current Config
func (c *DegradationConfig) DeepCopy() iface.ConfigValueItem {
result := &DegradationConfig{
Enable: c.Enable,
Percentage: c.Percentage,
}
return result
}

// EqualsTo returns true if the current Config equals to the other Config
func (c *DegradationConfig) EqualsTo(other iface.ConfigValueItem) bool {
o := other.(*DegradationConfig)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had better check whether c == nil.

return c.Enable == o.Enable && c.Percentage == o.Percentage
}

// Container is a wrapper for Config
type Container struct {
config atomic.Value
}

func NewContainer() *Container {
c := &Container{}
c.config.Store(defaultConfig)
return c
}

// NotifyPolicyChange to receive policy when it changes
func (c *Container) NotifyPolicyChange(cfg *DegradationConfig) {
c.config.Store(cfg)
}

func (c *Container) GetAclRule() acl.RejectFunc {
return func(ctx context.Context, request interface{}) (reason error) {
cfg := c.config.Load().(*DegradationConfig)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When users do not configure degration in kitex_client.json, this cfg would be nil.
You can take a try.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you just need to check whether cfg == nil here.

if !cfg.Enable {
return nil
}
if fastrand.Intn(100) < cfg.Percentage {
return errRejected
}
return nil
}
}
40 changes: 40 additions & 0 deletions pkg/degradation_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright 2024 CloudWeGo Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package degradation

import (
"context"
"errors"
"testing"

"github.com/cloudwego/kitex/pkg/acl"
"github.com/cloudwego/thriftgo/pkg/test"
)

var errFake = errors.New("fake error")

func invoke(ctx context.Context, request, response interface{}) error {
return errFake
}

func TestNewContainer(t *testing.T) {
container := NewContainer()
aclMiddleware := acl.NewACLMiddleware([]acl.RejectFunc{container.GetAclRule()})
test.Assert(t, errors.Is(aclMiddleware(invoke)(context.Background(), nil, nil), errFake))
container.NotifyPolicyChange(&DegradationConfig{Enable: false, Percentage: 100})
test.Assert(t, errors.Is(aclMiddleware(invoke)(context.Background(), nil, nil), errFake))
container.NotifyPolicyChange(&DegradationConfig{Enable: true, Percentage: 100})
test.Assert(t, errors.Is(aclMiddleware(invoke)(context.Background(), nil, nil), errRejected))
}
Loading