Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Newest code generates a bunch of errors #904

Closed
csidirop opened this issue Feb 7, 2023 · 2 comments
Closed

[BUG] Newest code generates a bunch of errors #904

csidirop opened this issue Feb 7, 2023 · 2 comments
Assignees
@sebastian-meyer
Labels
🐛 bug A non-security related bug.

Comments

@csidirop
Copy link
Contributor

csidirop commented Feb 7, 2023

Description

Using the current (31dbff3) 4.x branch together with the current state of the DFG-Viewer produces a lot of errors due to missing files/directories in the log, like:

 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/jPlayer/jquery.jplayer.min.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/OpenLayers/openlayers.css): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/jPlayer/blue.monday/css/jplayer.blue.monday.min.css): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/Search/Suggester.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/PageView.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/SearchInDocument.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/FullTextUtility.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/FulltextControl.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/FulltextDownloadControl.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/ImageManipulationControl.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/AnnotationControl.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/AnnotationParser.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/AltoParser.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/OLSources.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/OLStyles.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/OL.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/PageView/Utility.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/OpenLayers/openlayers.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/AudioPlayer/AudioPlayer.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/jPlayer/jquery.jplayer.min.js): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/OpenLayers/openlayers.css): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284 
 Core: Error handler (FE): PHP Warning: file_get_contents(/var/www/typo3/public/typo3conf/ext/dlf/Resources/Public/JavaScript/jPlayer/blue.monday/css/jplayer.blue.monday.min.css): failed to open stream: No such file or directory in /var/www/typo3/public/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 284

Furthermore, the viewer no longer loads the image of the page and throws following warnings and errors:

jQuery.Deferred exception: dlfUtils is not defined @http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigi.bib.uni-mannheim.de%2Ffileadmin%2Fvl%2Fubmaosi%2F59088%2F59088.xml:1345:21
e@http://localhost/typo3temp/assets/compressed/merged-5cd2c684b3b0382023a4cd9591800f34.js?1675767670:3:30038
Deferred/then/l/</t<@http://localhost/typo3temp/assets/compressed/merged-5cd2c684b3b0382023a4cd9591800f34.js?1675767670:3:30340
 undefined merged-5cd2c684b3b0382023a4cd9591800f34.js:3:31593


Uncaught ReferenceError: dlfUtils is not defined
    <anonymous> http://localhost/viewer?tx_dlf[id]=https://digi.bib.uni-mannheim.de/fileadmin/vl/ubmaosi/59088/59088.xml:1345
    e http://localhost/typo3temp/assets/compressed/merged-5cd2c684b3b0382023a4cd9591800f34.js?1675767670:3
    t http://localhost/typo3temp/assets/compressed/merged-5cd2c684b3b0382023a4cd9591800f34.js?1675767670:3

Reproduction

Steps to reproduce the behaviour:

  1. Install DFG-Viewer (via git or via composer)
  2. Go to the dlf directory
  3. Checkout the 4.x branch (or master)
  4. Load any page

Expected Behavior

Working like before!
The extetion on packagist ist still working. (but it's no surprise, because this version is almost a year old)
A few days before, the 4.x branch had not yet been updated. If I'm not completely wrong, the last version was commit 1e45e0c. With this version also no errors are caused.

Screenshots and Examples

grafik

grafik

Environment

  • OS version: Debian
  • RDBMS version: Maria DB (MySQL 5.5.5-10.9.3-MariaDB-1:10.9.3+maria~ubu2204 )
  • Apache Solr version: -
  • TYPO3 version: 10.4.35
  • PHP version: 7.4.33

Additional Context
@csidirop csidirop added the 🐛 bug A non-security related bug. label Feb 7, 2023
@sebastian-meyer sebastian-meyer self-assigned this Feb 7, 2023
@sebastian-meyer
Copy link
Member

sebastian-meyer commented Feb 7, 2023 •
edited
Loading

This was due to an incomplete pull request (#877) and should be fixed now.

The pull request aimed at renaming the directories Javascript and Flexforms to camel-case in accordance with the TYPO3 Coding Guidelines. But the actual renaming of the directories was for some reason not picked up correctly by git.

@sebastian-meyer sebastian-meyer changed the title Newest code generates a bunch of errors [BUG] Newest code generates a bunch of errors Feb 7, 2023
@csidirop
Copy link
Contributor Author

csidirop commented Feb 7, 2023 •
edited
Loading

Edit: That fixed that issue!

The missing page image has to be an unrelated issue I need to investigate. Thanks.

csidirop added a commit to csidirop/dfg-viewer that referenced this issue Feb 7, 2023
@csidirop
Fix dlf path: Javascript -> JavaScript
5f5da7e 
Fixes errors (kitodo/kitodo-presentation#904) after PR  (kitodo/kitodo-presentation#877) which renamed the directories Javascript and Flexforms to camel-case in accordance with the TYPO3 Coding Guidelines.

Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
csidirop added a commit to csidirop/dfg-viewer that referenced this issue Feb 7, 2023
@csidirop
Fix dlf path: Javascript -> JavaScript
4157866 
Fixes errors (kitodo/kitodo-presentation#904) after PR  (kitodo/kitodo-presentation#877) which renamed the directories Javascript and Flexforms to camel-case in accordance with the TYPO3 Coding Guidelines.

Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
csidirop added a commit to csidirop/dfg-viewer that referenced this issue Feb 7, 2023
@csidirop
Fix dlf path: Javascript -> JavaScript
a6d8062 
Fixes errors (kitodo/kitodo-presentation#904) after PR  (kitodo/kitodo-presentation#877) which renamed the directories Javascript and Flexforms to camel-case in accordance with the TYPO3 Coding Guidelines.

Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
@csidirop csidirop mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-meyer sebastian-meyer

Labels
🐛 bug A non-security related bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastian-meyer @csidirop