Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CI send coverage condition #33

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Fix: CI send coverage condition #33

merged 2 commits into from
Jan 20, 2024

Conversation

kitsuyui
Copy link
Owner

  • pull-request events are not triggered when a PR is merged
  • push events are not triggered when a PR created from a fork repository
  • So we need both to run tests on every PR and after merging

- pull-request events are not triggered when a PR is merged
- push events are not triggered when a PR created from a fork repository
- So we need both to run tests on every PR and after merging
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e6c635) 100.00% compared to head (6472591) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          700       700           
=========================================
  Hits           700       700           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit e9a16e7 into main Jan 20, 2024
11 checks passed
@kitsuyui kitsuyui deleted the fix-ci-send-coverage branch January 20, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant