Adjust library installation dialog buttons style (arduino#1401)

Closes arduino#1314.
kittaakos · Oct 20, 2022 · 93291b6 · 93291b6
1 parent 87ebcbe
commit 93291b6
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 15 deletions.
diff --git a/arduino-ide-extension/src/browser/library/library-list-widget.ts b/arduino-ide-extension/src/browser/library/library-list-widget.ts
@@ -119,30 +119,26 @@ export class LibraryListWidget extends ListWidget<
       message.appendChild(question);
       const result = await new MessageBoxDialog({
         title: nls.localize(
-          'arduino/library/dependenciesForLibrary',
-          'Dependencies for library {0}:{1}',
-          item.name,
-          version
+          'arduino/library/installLibraryDependencies',
+          'Install library dependencies'
         ),
         message,
         buttons: [
-          nls.localize('vscode/issueMainService/cancel', 'Cancel'),
           nls.localize(
-            'arduino/library/installOnly',
-            'Install {0} only',
-            item.name
+            'arduino/library/installWithoutDependencies',
+            'Install without dependencies'
           ),
-          nls.localize('arduino/library/installAll', 'Install all'),
+          nls.localize('arduino/library/installAll', 'Install All'),
         ],
         maxWidth: 740, // Aligned with `settings-dialog.css`.
       }).open();
 
       if (result) {
         const { response } = result;
-        if (response === 1) {
+        if (response === 0) {
           // Current only
           installDependencies = false;
-        } else if (response === 2) {
+        } else if (response === 1) {
           // All
           installDependencies = true;
         }
@@ -203,7 +199,11 @@ class MessageBoxDialog extends AbstractDialog<MessageBoxDialog.Result> {
       const button = this.createButton(text);
       const isPrimaryButton =
         index === (options.buttons ? options.buttons.length - 1 : 0);
-      button.classList.add(isPrimaryButton ? 'main' : 'secondary');
+      button.title = text;
+      button.classList.add(
+        isPrimaryButton ? 'main' : 'secondary',
+        'message-box-dialog-button'
+      );
       this.controlPanel.appendChild(button);
       this.toDisposeOnDetach.push(
         addEventListener(button, 'click', () => {

diff --git a/arduino-ide-extension/src/browser/style/index.css b/arduino-ide-extension/src/browser/style/index.css
@@ -109,6 +109,13 @@ button.secondary[disabled], .theia-button.secondary[disabled] {
   background-color: var(--theia-secondaryButton-background);
 }
 
+button.theia-button.message-box-dialog-button {
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  display: inline-block;
+}
+
 /* To make the progress-bar slightly thicker, and use the color from the status bar */
 .theia-progress-bar-container {
   width: 100%;

diff --git a/i18n/en.json b/i18n/en.json
@@ -254,12 +254,12 @@
       "addZip": "Add .ZIP Library...",
       "arduinoLibraries": "Arduino libraries",
       "contributedLibraries": "Contributed libraries",
-      "dependenciesForLibrary": "Dependencies for library {0}:{1}",
       "include": "Include Library",
-      "installAll": "Install all",
+      "installAll": "Install All",
+      "installLibraryDependencies": "Install library dependencies",
       "installMissingDependencies": "Would you like to install all the missing dependencies?",
       "installOneMissingDependency": "Would you like to install the missing dependency?",
-      "installOnly": "Install {0} only",
+      "installWithoutDependencies": "Install without dependencies",
       "installedSuccessfully": "Successfully installed library {0}:{1}",
       "libraryAlreadyExists": "A library already exists. Do you want to overwrite it?",
       "manageLibraries": "Manage Libraries...",