✨ Expect RunCatching for JS,Native and JVM for proper catch #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittinunf
reviewed
Aug 19, 2021
result/src/commonMain/kotlin/com/github/kittinunf/result/Factory.kt
Outdated
Show resolved
Hide resolved
kittinunf
reviewed
Aug 21, 2021
| package com.github.kittinunf.result | ||
|
|
||
| actual inline fun <V> runCatching(block: () -> V?): Result<V?, Throwable> { | ||
| return try { |
There was a problem hiding this comment.
Then we can use the new doTry function and there's no need for expect actual dance right?
There was a problem hiding this comment.
I am afraid that be impossible because it expects receivers.
There was a problem hiding this comment.
I made PR on top of yours #104
kittinunf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a huge help for property catching checks on platforms