✨ [Extension] Create success and failure extension functions #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are your thoughts on this @kittinunf? |
|
I think it is cool 👍 ! Let me check for minor formatting problem. |
kittinunf
reviewed
Aug 13, 2021
result/src/commonMain/kotlin/com/github/kittinunf/result/Result.kt
Outdated
Show resolved
Hide resolved
kittinunf
reviewed
Aug 14, 2021
result/src/commonMain/kotlin/com/github/kittinunf/result/Result.kt
Outdated
Show resolved
Hide resolved
|
Let's go! |
kittinunf
approved these changes
Aug 15, 2021
kittinunf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds extension functions for both
Result.successandResult.failuremethods.Description
We have been using an inner-company version of these extension functions for a while now and it have been proved massive productive and a lot more readable for converting/encapsulating direct returns, either for objects or exceptions.