Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Forge's MissingAttributeError on FuelError #661

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Jul 15, 2019

Description

Some how, Forge Error didn't catch property on FuelError.

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@iNoles iNoles self-assigned this Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #661 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     71.07%   71.11%   +0.03%     
  Complexity      297      297              
============================================
  Files            57       57              
  Lines          1490     1492       +2     
  Branches        193      194       +1     
============================================
+ Hits           1059     1061       +2     
  Misses          339      339              
  Partials         92       92
Impacted Files Coverage Δ Complexity Δ
.../java/com/github/kittinunf/fuel/forge/FuelForge.kt 50% <100%> (+10%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa0454...ce60239. Read the comment docs.

@iNoles iNoles requested a review from kittinunf July 15, 2019 05:14
@kittinunf
Copy link
Owner

kittinunf commented Jul 15, 2019

Since you are on this, can you also help bump up the version to jcenter as well?

Stopped to use component to when.
@kittinunf
Copy link
Owner

NICE!! approve!

@iNoles iNoles merged commit 5cc452c into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the iNoles-patch-1 branch July 16, 2019 15:40
@kittinunf kittinunf mentioned this pull request Jul 22, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants