Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[Bug] [Extension] Fix KotlinX serialization problem #733

Merged
merged 2 commits into from
Apr 5, 2020

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented Apr 4, 2020

Description

This PR fixes #720

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Have tested again mock server, and https://httpbin.org/.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #733 into master will increase coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #733      +/-   ##
============================================
+ Coverage     72.53%   72.71%   +0.18%     
  Complexity      301      301              
============================================
  Files            61       61              
  Lines          1511     1510       -1     
  Branches        205      205              
============================================
+ Hits           1096     1098       +2     
+ Misses          314      311       -3     
  Partials        101      101              
Impacted Files Coverage Δ Complexity Δ
.../kittinunf/fuel/serialization/FuelSerialization.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...kittinunf/fuel/core/requests/SuspendableRequest.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...kotlin/com/github/kittinunf/fuel/core/FuelError.kt 86.20% <0.00%> (+0.49%) 14.00% <0.00%> (ø%)
...ub/kittinunf/fuel/core/requests/DownloadRequest.kt 90.00% <0.00%> (+0.52%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e4ab7...e6c6108. Read the comment docs.

Copy link
Collaborator

@iNoles iNoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

Copy link

@arosenb2 arosenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for patching so quick!

@kittinunf kittinunf changed the title [Bug] [Extension] Fix KotlinX serialization problem 🐛[Bug] [Extension] Fix KotlinX serialization problem Apr 5, 2020
@kittinunf kittinunf merged commit 0fff191 into master Apr 5, 2020
@kittinunf kittinunf deleted the kv/fix-kotlinserialization-problem branch April 5, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants