Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven again #853

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Fix Maven again #853

merged 2 commits into from
Apr 9, 2023

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Apr 6, 2023

I have noticed that three JVM folders are not being uploaded to the Maven repo. I will be checking the snapshot once it is finished.

@iNoles iNoles self-assigned this Apr 6, 2023
@iNoles iNoles requested a review from kittinunf April 6, 2023 02:13
@kittinunf
Copy link
Owner

kittinunf commented Apr 8, 2023

What do you think about adding this into publication.gradle.kts file? So we don't have to manually add this into the subproject gradle file?

publications {
        if (project.name.substringAfterLast("-") == "jvm") {
            create<MavenPublication>("maven") {
                from(components["java"])
            }
        }
    }

Something like

Screenshot 2023-04-08 at 19 07 39

@iNoles
Copy link
Collaborator Author

iNoles commented Apr 8, 2023

I think that would be much better.

@kittinunf kittinunf merged commit cf9ea96 into main Apr 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-maven branch April 9, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants