Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maven Publications' Signing #865

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix Maven Publications' Signing #865

merged 1 commit into from
May 7, 2023

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented May 7, 2023

This will fix Maven Signing with proper tasks by depending on the correct sign class.

@iNoles iNoles requested a review from kittinunf May 7, 2023 02:11
@iNoles iNoles self-assigned this May 7, 2023
kittinunf
kittinunf approved these changes May 7, 2023
View reviewed changes
Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Let's goo!

@kittinunf kittinunf merged commit 66bd9c7 into main May 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_maven_publish branch May 7, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittinunf kittinunf kittinunf approved these changes

Assignees

@iNoles iNoles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iNoles @kittinunf