Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin 2.1.0 and Adjustments for WasmJS API Changes #980

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Jan 5, 2025

This PR updates the project to Kotlin 2.1.0, the latest version as of now. As part of this update, JetBrains has moved the Kotlin WasmJS browser API out of the Kotlin standard library into a separate repository: kotlinx-browser.

However, the kotlinx-browser library is still a Work in Progress (WIP) and is not yet recommended for end-users. Given this, additional considerations may be needed before fully integrating it into production.

@iNoles iNoles self-assigned this Jan 5, 2025
@iNoles iNoles requested a review from kittinunf January 5, 2025 19:57

plugins {
kotlin("multiplatform")
kotlin("plugin.serialization") version "2.0.21"
kotlin("plugin.serialization") version "2.1.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits] Do you think that we should move this version into toml file so we can control all of the versioning in one place? Not blocking this PR though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create a new PR for your suggestions.

@@ -4,7 +4,7 @@ plugins {
kotlin("jvm")
id("publication")
id("org.jetbrains.kotlinx.kover")
id("com.google.devtools.ksp") version "2.0.21-1.0.28"
id("com.google.devtools.ksp") version "2.1.0-1.0.29"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as question above.

Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ New PR for 2025 👍

@iNoles iNoles merged commit 1ca2763 into main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants