Generate SCSS and CSS vars from tokens file #138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also aligns more closely align with the design token specification
ryan-ludwig
force-pushed
the
style-dictionary
branch
from
e70097e
to
7136ee6
Compare
ryan-ludwig
force-pushed
the
style-dictionary
branch
from
7136ee6
to
8e44694
Compare
ryan-ludwig
commented
Nov 24, 2021
| $fonts-sans: PostGrotesk; | ||
| $font-sizes-base-sm: 16; | ||
| $font-sizes-base-md: 16; | ||
| $font-sizes-base-lg: 17; |
There was a problem hiding this comment.
All of these unitless values are kindof a pain to deal with in SASS and CSS. I wonder if we should add 'px' to them in the tokens file directly.
There was a problem hiding this comment.
Let's put px in tokens file.
ryan-ludwig
commented
Nov 24, 2021
| @@ -0,0 +1,175 @@ | |||
| /** | |||
| * Do not edit directly | |||
There was a problem hiding this comment.
Should we include these dist files in our repo, or only include them as part of the npm package as discussed here
https://stackoverflow.com/questions/31642477/how-to-publish-an-npm-package-with-distribution-files
There was a problem hiding this comment.
Should add a github action to rebuild these anytime tokens file is changed.
ryan-ludwig
changed the title
ryan-ludwig
requested review from
emuvente,
mcstover,
eddieferrer and
BoulderBrains
|
VUE-910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Style Dictionary as a tool automate this process.
This will be helpful for writing SASS in the old stack pages but utilizing up to date values from Kiva Classic.