Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use auth0 package file name to be compatible with es modules #418

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dyersituations
Copy link
Collaborator

@dyersituations dyersituations commented Jun 14, 2024

  • Apparently this is a known issue with using the Apollo package within an ES module
  • The Vue migration converted the ui repo to an ES module, so this changeset is needed (checkout page currently crashes the dev server 😄 )

@mcstover
Copy link
Collaborator

Does this work with the current UI repo state?

This may also affect how we "configure" kv-shop in CPS...

@dyersituations
Copy link
Collaborator Author

Does this work with the current UI repo state?

This may also affect how we "configure" kv-shop in CPS...

I do wonder about this too, and I will check both repos this morning.

@dyersituations dyersituations merged commit 948b8db into main Jun 14, 2024
5 checks passed
@dyersituations dyersituations deleted the fix-apollo-imports-node20 branch June 14, 2024 18:14
@dyersituations
Copy link
Collaborator Author

dyersituations commented Jun 14, 2024

@mcstover Between meetings and errands, tracked down a workaround to get kv-shop change here to work in the CPS repo: https://github.com/kiva/cms-page-server/pull/1305. These changes worked without tweaks in the ui repo, both old, and in the vue-3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants