Add iterative search/replace example to examples and README.md #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the AST example on README.md to use AstNode.descendants() as convenience iterator. 1. Using the iterator should be sufficient for most cases and is hopefully more familiar to people with experience at DOM/AST manipulation in other languages. 2. Full example in examples/iterator_replace.rs. It should be possible to drop the whole block from README into a file and run the demo. 3. Ref and lifetime allocation for this example is encapsulated in the Arena and AstNode methods.
1. Check comments for accuracy 2. Add basic unit test. Test checks output for string replacement and use of key html tags. Not sensitive to whitespace handling. 3. Remove unnecessary to_string() calls from main() and test function.
|
This is perfect — thank you so much, again! 😊🤍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revise #369
Add iterative string search/replace example to examples and README.md. The new example uses the
AstNode.descendants()iterator to examine all nodes in a tree. This should be easy to understand for newcomers. Code example is wrapped as a function which should be easy to copy/paste into a sandbox, file, or other setup.Note: example would need additional error checking for production code.
Basic "happy path" unit test in examples/iterator-replace.