Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arena_tree: panic if iterator invalidation causes trouble. #437

Merged
merged 2 commits into from
Jul 11, 2024
Merged

arena_tree: panic if iterator invalidation causes trouble. #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09d3f91
arena_tree: panic if iterator invalidation causes trouble.
kivikakk Jul 11, 2024
a57a719
arena_tree: remove unused allow(dead_code).
kivikakk Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/arena_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ make it a cell (`Cell` or `RefCell`) or use cells inside of it.

*/

#![allow(dead_code)]

use std::cell::Cell;
use std::fmt;

Expand Down Expand Up @@ -368,12 +366,7 @@ macro_rules! traverse_iterator {
Some(sibling) => Some(NodeEdge::Start(sibling)),
None => match node.parent.get() {
Some(parent) => Some(NodeEdge::End(parent)),

// `node.parent()` here can only be `None`
// if the tree has been modified during iteration,
// but silently stoping iteration
// seems a more sensible behavior than panicking.
None => None,
None => panic!("tree modified during iteration"),
},
}
}
Expand Down