Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zbarlight as alternative to pyzbar when it's not available #42

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

Cheaterman
Copy link
Contributor

@Cheaterman Cheaterman commented Oct 27, 2020

Everything in the title - pyzbar won't work on iOS.

EDIT: FWIW this PR is rebased onto #39 - it's probably a good idea to merge both, but if that's considered problematic I can probably split them.

@AndreMiras
Copy link
Collaborator

Thanks for giving it a look and spending time on it.
I have some suggestions. To begin with, could you not rebase on the other PR so we can better focus one what you're trying to address.
Also could you take a look into the unit tests which are failing?

@Cheaterman
Copy link
Contributor Author

@AndreMiras sure thing :-) I'll look into both, thanks for your early feedback!

@Cheaterman
Copy link
Contributor Author

I quickly looked at the failing tests - I thought it might be a good idea to normalize the code_types as lowercase because that used to be the case, but obviously people might rely on them as they are now :-) fixing!

TODO: Fix setup.py install/extra_requires accordingly, as well as
requirements in buildozer.spec for demo app
@Cheaterman
Copy link
Contributor Author

Alright, tests should succeed, and I think this generally should work as intended :-)

Copy link
Collaborator

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good, well done.
I wish you wrote additional tests for some of the new behaviour so nobody breaks it without noticing.
I'll merge still (and fix the linting) feel free to follow up with increase test coverage

@AndreMiras AndreMiras merged commit 9f38688 into kivy-garden:develop Oct 28, 2020
AndreMiras added a commit that referenced this pull request Oct 28, 2020
✅ Also adds tests
This is a follow up for #42
@AndreMiras
Copy link
Collaborator

Made the follow up PR with tests. Also introduced a class for the cross implementation to ease testing and avoid root level logic #46

AndreMiras added a commit that referenced this pull request Nov 2, 2020
AndreMiras added a commit that referenced this pull request Nov 2, 2020
@Cheaterman Cheaterman deleted the zbarlight branch April 26, 2023 19:05
@Cheaterman Cheaterman restored the zbarlight branch April 28, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants