Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup coverage testing, closes #1058 #1060

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

AndreMiras
Copy link
Member

Also enables report to coveralls.io via GitHub Action.
Note the COVERALLS_REPO_TOKEN was setup via:
https://github.com/kivy/buildozer/settings/secrets
And is accessible for repos admin via:
https://coveralls.io/github/kivy/buildozer

This is a follow up for #1059 branching from upstream to have access to the secrets

Also enables report to coveralls.io via GitHub Action.
Note the `COVERALLS_REPO_TOKEN` was setup via:
https://github.com/kivy/buildozer/settings/secrets
And is accessible for repos admin via:
https://coveralls.io/github/kivy/buildozer
@AndreMiras
Copy link
Member Author

Build is actually green but github as some leftover from the previous PR I think.
It's not ideal as it doesn't upload coveralls for PRs but only upon merge. But we have at least the coverage result from tox for PRs.
image

@AndreMiras AndreMiras requested a review from opacam April 10, 2020 14:23
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's see how it behaves.

Thanks!! 😄

@AndreMiras
Copy link
Member Author

Thanks for the check. Yes I'd say let's see, if it always break I would try to fix it

@AndreMiras AndreMiras merged commit 21d4157 into master Apr 10, 2020
@AndreMiras AndreMiras deleted the feature/coverage_testing branch April 10, 2020 14:31
@AndreMiras
Copy link
Member Author

Weird I realise I don't see one change I did on this PR 🤔
I've probably messed up somewhere, basically the change was to run the coverage only on push to master, that way the secrets.COVERALLS_REPO_TOKEN is only pulled when allowed.
Without it pull requests would probably fail. I'll see soon as I'm about to pull request now. If it fails then I'll bring the fix

@AndreMiras
Copy link
Member Author

Just confirmed and fixed via #1062

renabriseno68 added a commit to renabriseno68/flutter-doc-build-ozer-test that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants