Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Docker build/run job #1068

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

AndreMiras
Copy link
Member

Creates a dedicated job for Docker testing so it can run in parallel with the other tests.
Prior this change the CI was running in 3 minutes, it now runs in 2.

Creates a dedicated job for Docker testing so it can run in parallel
with the other tests.
Prior this change the CI was running in 3 minutes, it now runs in 2.
@AndreMiras AndreMiras requested a review from opacam April 13, 2020 16:57
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should move the Docker test into a new github workflow instead of a new job...anyway, LGTM since we reduce the timing of the tests 👍

Thanks!

@AndreMiras
Copy link
Member Author

Yes I was wondering the same, thanks for sharing, I think that would make sense too.
I'm not against a PR, I'm merging this one since it's already one step toward more isolation.
Thanks for the review

@AndreMiras AndreMiras merged commit 35cce59 into kivy:master Apr 13, 2020
@AndreMiras AndreMiras deleted the feature/dedicated_docker_job branch April 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants