Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops Python 2 support #1094

Merged
merged 1 commit into from
May 9, 2020
Merged

Drops Python 2 support #1094

merged 1 commit into from
May 9, 2020

Conversation

AndreMiras
Copy link
Member

Makes sure the user is warned at install time if using Python 2.

@AndreMiras
Drops Python 2 support
20bfa24 
Makes sure the user is warned at install time if using Python 2.
opacam
opacam approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Note: Aaa... I see that coverage test fails...maybe we should configure it with some threshold margin like we did with p4a?

@AndreMiras
Copy link
Member Author

Thanks @opacam yes I've increased the margin to 1% (p4a is 2%), let's see if we can hold it :)

@AndreMiras AndreMiras merged commit f564e1b into kivy:master May 9, 2020
@AndreMiras AndreMiras deleted the feature/python2_setup_message branch May 9, 2020 07:31
@misl6 misl6 mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @opacam