🗑️ Removes Python 2 constructions #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drops Python 2 imports - Drops `if IS_PY3` constructions - Drops `object` inheritance - Drops `__future__` imports - Drops `mocks` dependency - Uses Python 3 `super()`
inclement
approved these changes
May 18, 2020
There was a problem hiding this comment.
We know from experience that many users try to run buildozer under python2, whether deliberately or otherwise. I suppose there may not be a straightforward way to try to give an error about it, unlike with p4a, but it would be good to document what error they'll see so that it's (hopefully) easy to find.
|
Thanks for the review! |
|
|
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if IS_PY3constructionsobjectinheritance__future__importsmocksdependencysuper()