Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Linter fixes and README.md update #1118

Merged
merged 1 commit into from
May 25, 2020

Conversation

AndreMiras
Copy link
Member

Linter fixes:

  • E123 closing bracket does not match indentation of opening bracket's line
  • E125 continuation line with same indent as next logical line
  • E231 missing whitespace after ','
  • E265 block comment should start with '# '
  • E302 expected 2 blank lines, found 1
  • E305 expected 2 blank lines after class or function definition, found 1
  • E731 do not assign a lambda expression, use a def
  • F401 imported but unused
  • F821 undefined name
  • W605 invalid escape sequence

Also removes a Python 2 reference from the README.md

Linter fixes:
- E123 closing bracket does not match indentation of opening bracket's line
- E125 continuation line with same indent as next logical line
- E231 missing whitespace after ','
- E265 block comment should start with '# '
- E302 expected 2 blank lines, found 1
- E305 expected 2 blank lines after class or function definition, found 1
- E731 do not assign a lambda expression, use a def
- F401 imported but unused
- F821 undefined name
- W605 invalid escape sequence

Also removes a Python 2 reference from the README.md
@AndreMiras AndreMiras requested a review from opacam May 23, 2020 10:47
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice clean of flake8's exceptions

Thanks!!

@AndreMiras AndreMiras merged commit 43214d4 into kivy:master May 25, 2020
@AndreMiras AndreMiras deleted the feature/linter_fixes branch May 25, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants